Skip to content

feat: Add toggle to use pre-releases #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 5, 2025

Conversation

TheAabedKhan
Copy link
Member

Screenshots
pre-release

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Copy link
Contributor

@kitadai31 kitadai31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables Manager pre-releases, but currently, Manager update check is disabled for dev versions.

Future<bool> hasManagerUpdates() async {
if (!_managerAPI.releaseBuild) {
return false;
}

(This _managerAPI.releaseBuild variable will only be true if the app is release build and the version name doesn't contain -dev.)

This needs to be addressed.

@@ -20,6 +21,7 @@ class SAdvancedSection extends StatelessWidget {
title: t.settingsView.advancedSectionTitle,
children: const <Widget>[
SAutoUpdatePatches(),
SUsePrereleases(),
Copy link
Contributor

@kitadai31 kitadai31 Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Data sources" section is more suitable than "Advanced" section for this setting
because this setting exactly controls the data source

(However, this setting also controls updates to the Manager, so it might be questionable whether it belongs entirely to the data source?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data source is fine. Manager updates is also provided by a data source (API)

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, the toggle should warn the user and suggest not to use dev releases via a dialog. On toggle, the user should be prompted to restart to consume the new data.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@oSumAtrIX oSumAtrIX merged commit 89b48ce into ReVanced:dev May 5, 2025
github-actions bot pushed a commit that referenced this pull request May 5, 2025
# [1.25.0-dev.1](v1.24.1-dev.5...v1.25.0-dev.1) (2025-05-05)

### Bug Fixes

* Fix installation being cancelled at installation by not prematurely deleting patched APK  ([#2490](#2490)) ([dedcb3c](dedcb3c))
* Use device locale for app language (Default to English) ([#2488](#2488)) ([3074766](3074766))

### Features

* Add toggle to use pre-releases ([#2485](#2485)) ([89b48ce](89b48ce))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add feature/setting to pick pre-release patches instead
3 participants