Skip to content

fix namespace prefixes in longturtle serialization #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ddeschepper
Copy link

Summary of changes

Solves #3105 by storing the namespace manager of the graph that is to be serialized temporarily and reapplying it to the graph that is actually serialized by the implementation of the longturtle serializer.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@edmondchuc
Copy link
Contributor

Thank you for this! I had a local PR that I wrote up on the weekend but you beat me to it. :)

This partially resolves #3062 but just noting here the prefix declaration for rdf is still not preserved when the value rdf:type is used in the object position of a triple.

@ddeschepper
Copy link
Author

@edmondchuc is there anything I can do to help this get merged? I see some failing checks, but I'm unsure what causes them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants