Skip to content

get all graphs for a certain msaid #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

prestonzendev
Copy link

Solution

create getAllGraphsForMsaId to get all graphs for a certain MsaId

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for querying all graphs for a given MSA ID by introducing a new DTO and an API service method.

  • Added a new DTO (GraphsQueryAllParamsDto) to support query parameters for graph queries.
  • Introduced getAllGraphsForMsaId in the API service that leverages the new DTO and differentiates between public and private graph queries.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
libs/types/src/dtos/graph/index.ts Added new export for the graph-query-all-params DTO
libs/types/src/dtos/graph/graph-query-all-params.dto.ts Created a new DTO to encapsulate query parameters for graphs
apps/graph-api/src/api.service.ts Added a new method getAllGraphsForMsaId that utilizes the new DTO for retrieving graphs
Comments suppressed due to low confidence (1)

libs/types/src/dtos/graph/graph-query-all-params.dto.ts:13

  • The property name 'dsnpId' is used in a DTO for querying graphs by MSA ID, which may lead to confusion given the method name 'getAllGraphsForMsaId'. Consider renaming 'dsnpId' to 'msaId' for consistency.
dsnpId: string;

Copy link
Contributor

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this was the goal of the issue per #800

So:

  1. What part of Graph service (enhancements) #800 was Get all graphs for a certain MsaId #804 supposed to accomplish?
  2. At a minimum this code isn't used anywhere
  3. Needs tests
  4. Not sure how this is different from getGraphs

@wilwade wilwade closed this Apr 25, 2025
@shannonwells shannonwells deleted the feat/get-all-graphs-for-msaid branch May 23, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants