Skip to content

Graph service (enhancements) #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks
p5150j opened this issue Apr 9, 2025 · 2 comments
Open
6 tasks

Graph service (enhancements) #800

p5150j opened this issue Apr 9, 2025 · 2 comments
Labels
enhancement New feature or request graph-service

Comments

@p5150j
Copy link
Collaborator

p5150j commented Apr 9, 2025

Parent Issue: Refactor and Improve Graph Service Endpoints

As a developer integrating with the Graph service,
I want to refactor the current Graph service endpoints and align them with the graph-sdk conventions,
so that the API is more intuitive, maintainable, and compliant with DSNP standards.


Acceptance Criteria

  • Review SDK & Node Bridge

    • Review the graph-sdk GitHub repo to understand the expected API contracts and supported methods.
    • Review the Node bridge code to understand how it wraps or interacts with the SDK.
    • Check out https://spec.dsnp.org/ for graph spec
  • Evaluate Graph Service Implementation

  • Refactor Endpoint Naming and Methods

    • Rename or restructure endpoints to follow standard REST conventions and SDK practices (e.g., GET /graph instead of POST /getGraph).
    • Maintain backward compatibility where possible or introduce versioned controllers (e.g., /v2/graph) to avoid breaking changes.
  • Document Changes

    • Clearly document any breaking changes.
    • Update internal documentation and API references to reflect refactored endpoints.
  • Testing & Validation

    • Add integration tests to ensure SDK interactions are correct.
    • Validate that existing consumers are unaffected or informed of version changes.

Suggestions

Notes

  • Be mindful of breaking changes, especially in shared environments.
  • Any new or refactored controller should include versioning (e.g., v1, v2) to maintain backward compatibility.
@prestonzen
Copy link

prestonzen commented Apr 9, 2025

  • Any breaking changes make a V2 Graph Service controller instead of updating V1
  • Clarify naming convention in the service
  • Reference rust graph SDK dependency of how the graph is stored on the Frequency chain for easy API route creation: https://github.com/ProjectLibertyLabs/graph-sdk
  • Understanding the overall protocol interaction more https://spec.dsnp.org/

@aramikm
Copy link
Contributor

aramikm commented Apr 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request graph-service
Projects
None yet
Development

No branches or pull requests

4 participants