fix: blocking when creating opengraph images #33197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixes performance bottleneck in OpenGraph image generation by adding force_async parameter to bypass blocking exports. The change ensures OpenGraph image creation remains asynchronous, preventing slowdowns in the /sharing API endpoint.
- Added
force_async=Trueparameter tosynthetic_createmethod inposthog/api/exports.pyto override blocking behavior - Optimization ensures OpenGraph image generation doesn't get affected by 'blocking-exports' feature flag
- Performance improvement for /sharing API endpoint by preventing synchronous blocking
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
thmsobrmlr
approved these changes
Jun 5, 2025
jose-sequeira
pushed a commit
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving to blocking exports was also causing the creation of opengraph images to block, which was causing updates to the /sharing api endpoint to take forever.
add an async override and enable it on that path