feat(flags): make the config fields on /flags perfectly map to /decide
#33194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Makes feature flag configurations in /flags endpoint match exactly with /decide endpoint, focusing on field serialization and response structure consistency.
- Modified
autocapture_opt_outfield inrust/feature-flags/src/api/types.rsto be a non-optional boolean defaulting to false - Added
skip_serializing_if = "Option::is_none"for session recording canvas fields to match/decidebehavior - Removed
has_feature_flagsfield from response as it's not needed in API alignment - Added extensive test coverage using deterministic UUIDs for site app URLs instead of timestamps
- Ensures empty analytics capture endpoints are not exposed in responses
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
550
to
551
| let mut con = client.get_connection()?; | ||
| redis::cmd("FLUSHDB").execute(&mut con); |
There was a problem hiding this comment.
logic: Missing explicit error handling for Redis FLUSHDB command result. Should capture and return the result.
Suggested change
| let mut con = client.get_connection()?; | |
| redis::cmd("FLUSHDB").execute(&mut con); | |
| let mut con = client.get_connection()?; | |
| redis::cmd("FLUSHDB").execute(&mut con)?; |
There was a problem hiding this comment.
oh, actually, that was a commit that crept in; i didn't want to commit those files.
haacked
approved these changes
Jun 5, 2025
Comment on lines
550
to
551
| let mut con = client.get_connection()?; | ||
| redis::cmd("FLUSHDB").execute(&mut con); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
Before this change, there were a few fields that
/flagsdidn't serialize the exact same way asdecide. Here was the diff before (/flagson the left,/decideon the right)Before
and after
Changes
autocapture_opt_outcorrectlySessionRecordingConfigcorrectly"analytics"entry correctlyDid you write or update any docs for this change?
How did you test this code?
/decide.