feat: show a spinner when searching taxonomy #33190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
changed the base branch from
master
to
feat/allow-event-sorting-in-taxonomic-filter
pauldambra
commented
Jun 5, 2025
| @@ -76,71 +75,72 @@ function TaxonomicGroupTitle({ openTab }: { openTab: TaxonomicFilterGroupType }) | |||
| const { eventOrdering } = useValues(taxonomicFilterPreferencesLogic) | |||
| const { setEventOrdering } = useActions(taxonomicFilterPreferencesLogic) | |||
|
|
|||
| if (openTab === TaxonomicFilterGroupType.Events) { | |||
There was a problem hiding this comment.
ah, i missed i had this change too.
this is just refactoring the method
pauldambra
changed the title
|
Size Change: +2.07 kB (+0.06%) Total Size: 3.75 MB
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added event sorting functionality and visual feedback to the taxonomic filter, allowing users to sort events by name or last seen date with loading indicators during searches.
- Added new
taxonomicFilterPreferencesLogicto manage persistent sorting preferences with options for name, recently seen, or both - Implemented loading spinner in
InfiniteSelectResultsto provide visual feedback during searches - Enhanced
event_definition.pywith improved SQL query generation for multiple ordering expressions and date-specific sorting - Added comprehensive test coverage in
test_event_definition.pyfor various sorting scenarios including alphabetical and timestamp-based ordering - Protected new sorting functionality behind
TAXONOMIC_EVENT_SORTINGfeature flag
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+113
to
+114
| {!eventOrdering ? <IconCheck /> : <IconBlank />} | ||
| <span>Both</span> |
There was a problem hiding this comment.
style: 'Both' is not descriptive enough for the sorting option. Consider 'Recently seen + Name' for clarity.
veryayskiy
approved these changes
Jun 5, 2025
pauldambra
merged commit c44c92a
into
feat/allow-event-sorting-in-taxonomic-filter
102 of 103 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you get no visual feedback from the taxonomic filter when searching
let's give some
stacked on top of #33184