Skip to content

use /flags instead of /decide #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

use /flags instead of /decide #245

wants to merge 1 commit into from

Conversation

dmarticus
Copy link
Contributor

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Next" section. Make sure the entry includes this PR's number.
Example:

## Next
- use /flags instead of /decide ([#245](https://github.com/PostHog/posthog-android/pull/245))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 18f2a64

@marandaneto
Copy link
Member

we probably want to rename the json files as well https://github.com/PostHog/posthog-android/tree/main/posthog/src/test/resources/json since they are all called something decide

@marandaneto
Copy link
Member

marandaneto commented May 20, 2025

since the response format changes, we need to fix/test this as well


and
ideally in a back compatible way.
js-lite (rn) caused an issue because that wasn't accounted for https://posthog.slack.com/archives/C04MZFDA5KK/p1747734697154639?thread_ts=1746644228.860679&cid=C04MZFDA5KK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants