Skip to content

Marshmallow 4 upgrades #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

jdebacker
Copy link
Member

This PR addresses Issues #144 and #143 by making ParamTools compatible with Marshmallow 4.0. The Marshmallow guide (which doesn't have a lot of detail) summarizing the changes.

@jdebacker
Copy link
Member Author

So far, this PR has:

  • Removed ordered objects (since they are now all ordered by default) (as done in PR Marshmallow 4 upgrades #145)
  • Set a context attribute in the BaseValidatorSchema, with the default being an empty dictionary

I'm currently stuck on how to create the fields attribute that is access, e.g., in the Parameters.specification method. Marshmallow had previously inferred fields, but now does not.

cc @hdoupe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant