Skip to content

Add XY metadata #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joaomamede
Copy link

Added code to include X and Y stage position in the metadata dictionary.

@rbnvrw rbnvrw self-assigned this Nov 10, 2021
@rbnvrw rbnvrw added this to the Version 3.3.1 milestone Nov 10, 2021
@rbnvrw rbnvrw linked an issue Nov 10, 2021 that may be closed by this pull request
@rbnvrw
Copy link
Member

rbnvrw commented Nov 10, 2021

@joaomamede there are some failing tests (see for example https://github.com/rbnvrw/nd2reader/runs/4170041379?check_suite_focus=true) ValueError: bytes length not a multiple of item size I think it is unrelated to your changes, but I'd like to fix it first before merging just to be sure. I hope to be able to look at it next week, or if you have an idea what it could be, feel free to look at it in the meantime.

@joaomamede
Copy link
Author

joaomamede commented Nov 18, 2021

I had done the tests locally, but I couldn't find any of the errors to be connected with the changes. I just changed the metadata attribution in the dictionary, not even the file reading.

I has been working well in linux and windows by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving metadata: Add X and Y stage coordinates in Metadata.
2 participants