This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Fix "addEventListener is not a function" #267
Merged
+18
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickersoft
suggested changes
Oct 16, 2020
|
|
||
| if (Util.isFunction(options.onError)) | ||
| notification.addEventListener('error', options.onError); | ||
| if (Util.isFunction(options.onError)) |
There was a problem hiding this comment.
Overall looks good, but it looks like a bunch of these changes are just adding indents? Or am I missing something?
There was a problem hiding this comment.
Yes, these are just indents caused by if (Util.isFunction(notification.addEventListener)) that wraps these if statements.
Nickersoft
approved these changes
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! We kept getting "a.addEventListener is not a function" from this part of the code in our Electron environment. We believe this may have to do with #68 and it was partially fixed by #75. In our case this issue is caused by
notificationbeing an empty object.