[no-relnote] Add E2E for libnvidia-container #1118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an end-to-end test for the nvidia-container-cli to help catch regressions in libnvidia-container.
- Introduces a new Go test file under tests/e2e to run E2E validations using Ginkgo and Gomega.
- Updates the Makefile to focus on the nvidia-container-cli tests by default.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/nvidia-container-cli_test.go | New E2E test implementation for validating the nvidia-container-cli. |
| tests/e2e/Makefile | Updated test target to add a focus flag for running nvidia-container-cli tests. |
Pull Request Test Coverage Report for Build 15472130908Details
💛 - Coveralls |
elezar
reviewed
May 30, 2025
ArangoGutierrez
force-pushed
the
e2e/nvidia-container-cli
branch
from
67cc2ec to
903737e
Compare
ArangoGutierrez
force-pushed
the
e2e/nvidia-container-cli
branch
5 times, most recently
from
d0a338e to
8c42c14
Compare
|
Tests pass, PR ready for review @elezar |
ArangoGutierrez
force-pushed
the
e2e/nvidia-container-cli
branch
from
8c42c14 to
d905a49
Compare
elezar
reviewed
Jun 5, 2025
Comment on lines
31
to
33
| docker run -d --name test-nvidia-container-cli \ | ||
| --privileged \ | ||
| --runtime=nvidia \ |
There was a problem hiding this comment.
It is not scalable to have to MOUNT everything into this container. Note that when we still had some simple integration tests in the toolkit we used
Can we rather adapt this?
There was a problem hiding this comment.
sure, will work on that. we need to make this test more robust and scalable
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
e2e/nvidia-container-cli
branch
from
d905a49 to
9674787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an E2E test for the nvidia-container-cli that will allow us to catch regressions on libnvidia-container