-
Notifications
You must be signed in to change notification settings - Fork 353
[no-relnote] Add E2E for libnvidia-container #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[no-relnote] Add E2E for libnvidia-container #1118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an end-to-end test for the nvidia-container-cli to help catch regressions in libnvidia-container.
- Introduces a new Go test file under tests/e2e to run E2E validations using Ginkgo and Gomega.
- Updates the Makefile to focus on the nvidia-container-cli tests by default.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tests/e2e/nvidia-container-cli_test.go | New E2E test implementation for validating the nvidia-container-cli. |
tests/e2e/Makefile | Updated test target to add a focus flag for running nvidia-container-cli tests. |
Pull Request Test Coverage Report for Build 15472130908Details
💛 - Coveralls |
67cc2ec
to
903737e
Compare
d0a338e
to
8c42c14
Compare
Tests pass, PR ready for review @elezar |
8c42c14
to
d905a49
Compare
docker run -d --name test-nvidia-container-cli \ | ||
--privileged \ | ||
--runtime=nvidia \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not scalable to have to MOUNT everything into this container. Note that when we still had some simple integration tests in the toolkit we used
testing::docker::dind::setup() { |
Can we rather adapt this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will work on that. we need to make this test more robust and scalable
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
d905a49
to
9674787
Compare
This patch adds an E2E test for the nvidia-container-cli that will allow us to catch regressions on libnvidia-container