feat: ДЗ 9. Реализация навигации по субкатегории #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letto228
reviewed
Dec 8, 2023
| @@ -38,6 +38,10 @@ const routes: Routes = [ | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
| path: ':id', | |||
There was a problem hiding this comment.
Почему решил добавить отдельным динамическим сегментом :id? Почему не в связке products-list/:id. На мой взгляд пути для отображения списка продуктов - products-list and products-list/:id выглядят консистентней нежели products-list and :id.
Что думаешь?
| @@ -12,6 +12,7 @@ | |||
| mat-button | |||
| hideToggle | |||
| class="sub-catigory" | |||
| [routerLink]="[subCategory._id]" | |||
There was a problem hiding this comment.
А как думаешь, какая навигация тут должна быть: абсолютная или относительная?
| constructor(private readonly router: Router) { | ||
| } | ||
|
|
||
| onClick(subCategory: string){ |
There was a problem hiding this comment.
Уже не нужно? Осталось после тестирования другой реализации?
Comment on lines
+28
to
+33
| if(subCategoryId){ | ||
| this.productsStoreService.loadProducts(subCategoryId) | ||
| return | ||
| } | ||
| this.productsStoreService.loadProducts() | ||
| }) |
There was a problem hiding this comment.
Почему не просто передаешь subCategoryId в метод? Он же умеет работать с null🤔
Suggested change
| if(subCategoryId){ | |
| this.productsStoreService.loadProducts(subCategoryId) | |
| return | |
| } | |
| this.productsStoreService.loadProducts() | |
| }) | |
| this.productsStoreService.loadProducts(subCategoryId) | |
| }) |
Comment on lines
+24
to
+26
| map(paramMap=>{ | ||
| return paramMap.get("id") | ||
| }), |
There was a problem hiding this comment.
Рекомендую в таких случаях сокращать запись
Suggested change
| map(paramMap=>{ | |
| return paramMap.get("id") | |
| }), | |
| map(paramMap => paramMap.get("id")), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.