Skip to content

Want to add support for KHR_audio_emitter in interactivity graph #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dqmachine opened this issue Mar 25, 2025 · 5 comments
Closed

Want to add support for KHR_audio_emitter in interactivity graph #827

dqmachine opened this issue Mar 25, 2025 · 5 comments

Comments

@dqmachine
Copy link

dqmachine commented Mar 25, 2025

Pulled the extensions/KHR_interactivity branch and created a branch, Audio_Emitter, underneath that supports the KHR_audio_emitter extension. I want to commit this branch when I have permission.

@hybridherbst
Copy link
Collaborator

Thanks! Is there a particular reason why you can't make a PR from a fork?

@dqmachine
Copy link
Author

dqmachine commented Mar 27, 2025

Sorry for the delayed response. I tried to push my branch up (the branch hangs off the extensions/KHR_interactivity branch) into the repo to do a compare/PR, but i get a 403 error.

"fatal: unable to access 'https://github.com/KhronosGroup/UnityGLTF.git/': The requested URL returned error: 403"

Do i need to be added as a contributor or do i not understand the process?

@marwie
Copy link
Contributor

marwie commented Mar 27, 2025

Hi @dqmachine

As Felix said you need to fork this repository and push your changes there (to your forked repo). You can then open a pull request.

Checkout this guide if you're new to the process, it explains everything:
https://srivastavayushmaan1347.medium.com/how-to-fork-a-repository-make-changes-and-submit-a-pull-request-on-github-c05b0462403d

Here's GitHub's documentation about it: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

@dqmachine
Copy link
Author

Got it. Thanks. I'm not used to working with opensource repos.

@hybridherbst
Copy link
Collaborator

Closing this issue, the PR is here: #829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants