Skip to content

PBRGraph shader does not work for points topology #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 7 tasks
hybridherbst opened this issue Feb 24, 2025 · 1 comment
Open
4 of 7 tasks

PBRGraph shader does not work for points topology #816

hybridherbst opened this issue Feb 24, 2025 · 1 comment
Assignees
Labels
bug spec compliance Bug that needs fixed to be compliant with the glTF 2.0 spec

Comments

@hybridherbst
Copy link
Collaborator

Describe the bug 💬

The attached model has some points topology in it.
Unity tries to render it, but fails with a shader error:

Drawing with MeshTopology.Points, yet the vertex program 'UnityGLTF/PBRGraph' does not have PSIZE output.

I think that points should probably be rendered with a custom unlit shader that supports map + color + vertex color (lighting on them doesn't really make sense), but care has to be taken to ensure compatibility with BiRP, URP, HDRP.

Steps to reproduce 🔢

  1. Download 20250223-MixedTopologySphere.glb.zip
  2. Import in Unity at edit time

Files to reproduce the issue ♻

No response

Editor Version 🎲

2021.3

Render Pipeline and version

URP

UnityGLTF Version

2.14

Operating System 👩‍💻

macOS

When does this problem happen?

  • Editor Import
  • Runtime Import
  • Editor Export
  • Runtime Export

Additional Info 📜

Related: atteneder/glTFast#246

Validations 🩹

@hybridherbst hybridherbst added bug spec compliance Bug that needs fixed to be compliant with the glTF 2.0 spec labels Feb 24, 2025
@hybridherbst
Copy link
Collaborator Author

Unity QA responded to the issue: Shader Graph does not support points topology. So we should probably switch to a custom unlit shader for points topologies that only supports base color and base map or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug spec compliance Bug that needs fixed to be compliant with the glTF 2.0 spec
Projects
None yet
Development

No branches or pull requests

2 participants