Fix vkloadtests build with cmake 3.29+ #1010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vkloadtests RPATH on iOS.
3.29+ recognize .xcframeworks so FindVulkan was finding MoltenVK.xcframework which has only a static library not suitable for use in the app bundle. Removal of some tabs from CMakeLists.txt is along for the ride.
MarkCallow
added a commit
that referenced
this pull request
Apr 14, 2025
Port Linux, macOS and web workflows from Travis to GitHub Actions. Splits the Travis workflow into separate Linux, iOS & macOS, web and check-reuse workflows. Adds a new `manual` workflow for requesting build of all platforms. Incorporates PR #1010 for fixes to build CMake 3.29+ as runners have recent CMake versions. Co-authored-by: Mark Callow <[email protected]>
|
Incorporated in PR #1004. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with vkloadtests for iOS not running, caused by a change a little while ago.
Fixes a build issue with vkloadtests for macOS with recent versions of CMake that recognize .xcframeworks.
@MathiasMagnus you may need to merge this into your GitHub actions PR in order to have successful builds, depending on what version of CMake is on the CI runners.