Skip to content

fix(config): Ensure that "triggerOnMaskChange" and "shownMaskExpression" are received in "NgxMaskService" when provided through "provideNgxMask()". #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DavidMaza
Copy link

Ensure that "triggerOnMaskChange" and "shownMaskExpression" are received in "NgxMaskService" when provided through "provideNgxMask()".

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When values for "triggerOnMaskChange" and "shownMaskExpression" are provided through "provideNgxMask()", the configuration values don't flow through to the NgxMaskService and aren't applied to the field.

Issue Number: N/A

What is the new behavior?

Providing values for "triggerOnMaskChange" and "shownMaskExpression" through "provideNgxMask()" will inject the values into NgxMaskService which will be used when masking. For example:

provideNgxMask({
  triggerOnMaskChange: true,
  showMaskTyped: true,
  shownMaskExpression: '0000'
})

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…on" are received in "NgxMaskService" when provided through "provideNgxMask()".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant