Fix when fetching from DOI: Dialog selects field data based on validity

CHANGELOG.md

@@ -33,6 +33,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Fixed
 
+- We fixed an issue where when fetching from DOI, dialog selects field data based on validity. [#12549](https://github.com/JabRef/jabref/issues/12549)
 - We fixed an issue where the F4 shortcut key did not work without opening the right-click context menu. [#6101](https://github.com/JabRef/jabref/pull/6101)
 - We fixed an issue where the file renaming dialog was not resizable and its size was too small for long file names. [#12518](https://github.com/JabRef/jabref/pull/12518)
 - We fixed an issue where the name of the untitled database was shown as a blank space in the right-click context menu's "Copy to" option. [#12459](https://github.com/JabRef/jabref/pull/12459)

src/main/java/org/jabref/gui/mergeentries/FetchAndMergeEntry.java

@@ -22,6 +22,7 @@
 import org.jabref.logic.importer.ImportCleanup;
 import org.jabref.logic.importer.WebFetcher;
 import org.jabref.logic.importer.WebFetchers;
+import org.jabref.logic.importer.fetcher.DoiFetcher;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.util.BackgroundTask;
 import org.jabref.logic.util.TaskExecutor;
@@ -110,6 +111,9 @@ private void showMergeDialog(BibEntry originalEntry, BibEntry fetchedEntry, WebF
         dialog.setTitle(Localization.lang("Merge entry with %0 information", fetcher.getName()));
         dialog.setLeftHeaderText(Localization.lang("Original entry"));
         dialog.setRightHeaderText(Localization.lang("Entry from %0", fetcher.getName()));
+        if (fetcher instanceof DoiFetcher) {
+            dialog.autoSelectBetterFields();
+        }
         Optional<BibEntry> mergedEntry = dialogService.showCustomDialogAndWait(dialog).map(EntriesMergeResult::mergedEntry);
 
         if (mergedEntry.isPresent()) {

src/main/java/org/jabref/gui/mergeentries/MergeEntriesDialog.java

@@ -64,4 +64,8 @@ public void setRightHeaderText(String rightHeaderText) {
     public void configureDiff(ShowDiffConfig diffConfig) {
         threeWayMergeView.showDiff(diffConfig);
     }
+
+    public void autoSelectBetterFields() {
+        threeWayMergeView.autoSelectBetterFields();
+    }
 }

src/main/java/org/jabref/gui/mergeentries/newmergedialog/FieldRowView.java

@@ -30,6 +30,10 @@
  */
 public class FieldRowView {
     private static final Logger LOGGER = LoggerFactory.getLogger(FieldRowView.class);
+    private static final int YEAR_LOWER = 1800;
+    private static final int YEAR_DIF = 10;
+    private static final int YEAR_UPPER_DIF = 100;
+    private static final String MISC = "misc";
 
     protected final FieldRowViewModel viewModel;
 
@@ -212,4 +216,8 @@ public boolean hasEqualLeftAndRightValues() {
     public String toString() {
         return "FieldRowView [shouldShowDiffs=" + shouldShowDiffs.get() + ", fieldNameCell=" + fieldNameCell + ", leftValueCell=" + leftValueCell + ", rightValueCell=" + rightValueCell + ", mergedValueCell=" + mergedValueCell + "]";
     }
+
+    public void autoSelectBetterValue_1() {
+        viewModel.autoSelectBetterValue();
+    }
 }

src/main/java/org/jabref/gui/mergeentries/newmergedialog/FieldRowViewModel.java

@@ -1,5 +1,7 @@
 package org.jabref.gui.mergeentries.newmergedialog;
 
+import java.time.Year;
+
 import javax.swing.undo.AbstractUndoableEdit;
 import javax.swing.undo.CannotRedoException;
 import javax.swing.undo.CannotUndoException;
@@ -37,6 +39,10 @@ public enum Selection {
         NONE
     }
 
+    private static final int YEAR_LOWER = 1800;
+    private static final int YEAR_DIF = 10;
+    private static final int YEAR_UPPER_DIF = 100;
+    private static final String MISC = "misc";
     private final Logger LOGGER = LoggerFactory.getLogger(FieldRowViewModel.class);
     private final BooleanProperty isFieldsMerged = new SimpleBooleanProperty(Boolean.FALSE);
 
@@ -282,4 +288,49 @@ public void redo() throws CannotRedoException {
             setRightFieldValue(mergedFields);
         }
     }
+
+    /**
+     * Method for selecting the 'Better' year value.
+     * If the local year is out of a reasonable range (e.g., before 1800 or 100 years after current year as determined by the System Clock) or differs from the DOI year by more than 10 years, it will choose the more recent year out of the two.
+     */
+    public void autoSelectBetterValue() {
+        String field_1 = getField().getDisplayName();
+        if (field_1 == null) {
+            return;
+        }
+        field_1 = field_1.trim().toLowerCase();
+
+        String leftVal = getLeftFieldValue();
+        String rightVal = getRightFieldValue();
+        if (leftVal == null || rightVal == null) {
+            return;
+        }
+        leftVal = leftVal.trim();
+        rightVal = rightVal.trim();
+
+        // Logic for auto selection based on field name
+        // Default is right value
+        if ("year".equals(field_1)) {
+            try {
+                int leftYear = Integer.parseInt(leftVal);
+                int rightYear = Integer.parseInt(rightVal);
+                if (leftYear < YEAR_LOWER || leftYear > (Year.now().getValue() + YEAR_UPPER_DIF)) {
+                    selectRightValue(); // Select right value if left year is out of range, note that work created before Year 1800 will still be correctly processed
+                } else if (Math.abs(leftYear - rightYear) > YEAR_DIF) {
+                    // Select value based on a difference condition
+                    if (leftYear > rightYear) {
+                        selectLeftValue();
+                    } else {
+                        selectRightValue();
+                    }
+                }
+            } catch (NumberFormatException e) {
+                selectRightValue();
+            }
+        } else if ("type".equals(field_1)) {
+            if (MISC.equalsIgnoreCase(leftVal)) {
+                selectRightValue(); // Select right value if left value is "misc"
+            }
+        }
+    }
 }

src/main/java/org/jabref/gui/mergeentries/newmergedialog/ThreeWayMergeView.java

@@ -200,4 +200,14 @@ public BibEntry getRightEntry() {
     public void saveConfiguration() {
         toolbar.saveToolbarConfiguration();
     }
+
+    /**
+     * Directs to the method autoSelectBetterValue() in FieldRowViewModel.java
+     * Select 'Better' values for each field row in the Entry
+     */
+    public void autoSelectBetterFields() {
+        for (FieldRowView row : fieldRows) {
+            row.autoSelectBetterValue_1();
+        }
+    }
 }

src/test/java/org/jabref/gui/mergeentries/FieldRowViewModelTest.java

@@ -124,6 +124,7 @@ void hasEqualLeftAndRightValuesShouldReturnTrueIfKeywordsAreEqual() {
     void selectLeftValueShouldBeCorrect() {
         var monthFieldViewModel = createViewModelForField(StandardField.MONTH);
         monthFieldViewModel.selectLeftValue();
+
         assertEquals(FieldRowViewModel.Selection.LEFT, monthFieldViewModel.getSelection());
         assertEquals(Optional.of(""), Optional.ofNullable(monthFieldViewModel.getMergedFieldValue()));