Skip to content

Adding "wind-charge" flag (1.21.1+) #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RedstoneFuture
Copy link
Member

@RedstoneFuture RedstoneFuture commented Oct 12, 2024

Overview

This PR adds the "wind-charge" flag to prevent the block-update of minecraft:wind_charge and minecraft:breeze_wind_charge.

Description

  • adding new flag "wind-charge" to allow or block the block-trigger behavior (default false)
    • I check for build permission (added, trusted, owner) so that the permissions are similar to projectiles flag and users don't have to turn on the flag for everyone just because they want to work with it.
    • The projectiles flag must also be activated so that other players can use the wind-charges. I think it makes sense because the projectiles flag still seems to be ordered higher. -> wind-charge is more critical, so it has its own additional flag.
    • explosion flag still manage the explosion behavior (explosion clouds), but this is not necessary for the wind-charge effect.
  • adding checks in the ProjectileEventListener1211

TODO (draft PR)

  • merge improved 1.21.1 support for PlotSquared to use the EntityType check for "wind-charge" (existing commits for 1.21.1 support are temporary here), e.g. # 4582

Submitter Checklist

Preview Give feedback

@github-actions github-actions bot added the Feature This PR proposes a new feature label Oct 12, 2024
@RedstoneFuture RedstoneFuture changed the title Adding "windcharge" flag (1.21.1+) Adding "wind-charge" flag (1.21.1+) Oct 12, 2024
Copy link

github-actions bot commented Nov 1, 2024

Please take a moment and address the merge conflicts of your pull request. Thanks!

Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@RedstoneFuture RedstoneFuture marked this pull request as ready for review February 23, 2025 23:20
@RedstoneFuture RedstoneFuture requested a review from a team as a code owner February 23, 2025 23:20
@RedstoneFuture RedstoneFuture marked this pull request as draft February 23, 2025 23:20
@RedstoneFuture RedstoneFuture requested review from a team and removed request for a team February 23, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR proposes a new feature unresolved-merge-conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant