Skip to content

newsraft 0.29 (new formula) #221371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vaygr
Copy link
Contributor

@vaygr vaygr commented Apr 25, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Apr 25, 2025
@vaygr vaygr force-pushed the newsraft-new-formula branch from 4b13d36 to c2f9c30 Compare April 25, 2025 00:35
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Apr 25, 2025
@vaygr
Copy link
Contributor Author

vaygr commented Apr 25, 2025

@chenrui333 is there a way to bypass non-system ncurses library check? This is required on most macOS versions, and there are several similar formulae: lynx, bash, mtm, openvi, trader, sysdig, angband, ncdu, rmw, etc.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 26, 2025
@chenrui333
Copy link
Member

@chenrui333 is there a way to bypass non-system ncurses library check?

yeah, that error can be ignored. (which only happens for the new formula check)

@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Apr 26, 2025
@p-linnane p-linnane added CI-skip-new-formulae Pass --skip-new to brew test-bot. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 26, 2025
# newer ncurses required on older macOS versions
depends_on "ncurses"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know which versions? If so, we can use uses_from_macos "ncurses", since: :foo. This would allow us to only install brewed ncurses on systems that need it. We also do not need the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-linnane at first I thought Sequoia, but after failed build I looked closely, and it's still lower than required 6.1, so I removed the comment and left it as is.

@vaygr vaygr force-pushed the newsraft-new-formula branch from c2f9c30 to ac3da59 Compare April 26, 2025 22:31
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 26, 2025
@vaygr vaygr force-pushed the newsraft-new-formula branch from ac3da59 to bc1a81d Compare April 26, 2025 22:55
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. long build Set a long timeout for formula testing and removed automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Apr 26, 2025
@vaygr vaygr force-pushed the newsraft-new-formula branch from bc1a81d to 331fbea Compare April 26, 2025 23:03
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-skip-new-formulae Pass --skip-new to brew test-bot. long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants