-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
newsraft 0.29 (new formula) #221371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
newsraft 0.29 (new formula) #221371
Conversation
4b13d36
to
c2f9c30
Compare
@chenrui333 is there a way to bypass non-system |
yeah, that error can be ignored. (which only happens for the new formula check) |
Formula/n/newsraft.rb
Outdated
# newer ncurses required on older macOS versions | ||
depends_on "ncurses" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know which versions? If so, we can use uses_from_macos "ncurses", since: :foo
. This would allow us to only install brewed ncurses
on systems that need it. We also do not need the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-linnane at first I thought Sequoia, but after failed build I looked closely, and it's still lower than required 6.1, so I removed the comment and left it as is.
c2f9c30
to
ac3da59
Compare
ac3da59
to
bc1a81d
Compare
bc1a81d
to
331fbea
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?