Skip to content

mailcatcher: fix missing UI assets #221316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Continuing #174319.

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue labels Apr 24, 2025
@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 24, 2025
Co-authored-by: Samuel Cochran <[email protected]>

Signed-off-by: Patrick Linnane <[email protected]>

mailcatcher: patch Rakefile

Signed-off-by: Patrick Linnane <[email protected]>
@p-linnane p-linnane force-pushed the mailcatcher-ui-fix branch from f48c31a to 85a1e97 Compare April 24, 2025 16:51
@p-linnane
Copy link
Member Author

p-linnane commented Apr 24, 2025

@sj26 The issue we are running into here is that the Rakefile is running tests requiring RSpec unconditionally. This is not something we do for our packages in Homebrew/core. Our options here would be to patch the formula (like I did for $LOAD_PATH, since mail_catcher/version was not being found) to remove the RSpec tests, or for tests to not be run by default in the Rakefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. nodejs Node or npm use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant