Refactor the 'Sample Points' node to use Kurbo API. #2629
+67
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
reviewed
May 3, 2025
Comment on lines
+90
to
+92
| let lengths = segments_length | ||
| .map(|segments_length| segments_length.to_vec()) | ||
| .unwrap_or(bezpath.segments().map(|segment| segment.perimeter(PERIMETER_ACCURACY)).collect()); |
There was a problem hiding this comment.
Because the global_euclidean_to_local_euclidean function needed &[f64] and also to calculate total_length. I tried without coverting the segments length to Vec but could not figure out a way to do that.
There was a problem hiding this comment.
To calculate the lengths of the segment when pre-computed it not provided then I will have to create Vec of f64s to store the lengths right?
added 2 commits
May 4, 2025 10:45
…better approximate euclidean position on a path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #