Fix reference phase bug #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardt94
force-pushed
the
ref_phase_mask_fix
branch
from
63d0e50 to
74387f4
Compare
mcgarth
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcgarth noticed a bug where areas outside the frame contained non-NaN values in the phase closure loop plots. I traced this back to the reference phase subtraction - this was done without masking the no-data values in the source dataset, so if the no-data val was zero, no-data pixels would become non-zero after subtracting the reference phase, and then be treated as valid pixels downstream. This PR converts no-data pixels to NaN before doing ref phase subtraction.