Fix issue 310 #335
Merged
Fix issue 310 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardt94
approved these changes
May 12, 2021
There was a problem hiding this comment.
Looks good. You've added comments which make the reference phase correction process more clear in the code, as well as fixing the bug. Comments as noted - we'll eventually want a more robust fix in APS, up to you whether you want to flag this in comments as a "to do" for later. The offset strategy should work well enough for now.
basaks
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a circumventive measure to address the Issue identified at: #310
Specifically, I add a small value of 1e-20 to the reference phase that is subtracted from each interferogram. This avoids pixels taking the exact value of zero (0.0) and possibly being converted to NaN downstream in the workflow.