Skip to content

feat: add Land Cover Thematic Accuracy indicator #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

feat: add Land Cover Thematic Accuracy indicator #893

wants to merge 40 commits into from

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Apr 29, 2025 •
edited
Loading

TODO

  • Use more descriptive ENUM names for CorineClass.
  • Add Plotly figure
  • Support single CorineClass class
  • Add proper indicator description including methodology/workflow (first as docstring to in indicator.py)
  • Remove matplotlib dep
  • Investigate UdefinedMetricWarning
    # Recall is ill-defined and being set to 0.0 in labels with no
    # true samples. Use zero_division parameter to control this
    # behavior.

Description

Please add a clear and concise description of what your PR solves.

Corresponding issue

Closes #

New or changed dependencies

Checklist

  • I have ensured my branch is mergeable with main (e.g. through git rebase main if necessary)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have added new Hurl regression tests and checked all existing tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@matthiasschaub matthiasschaub marked this pull request as draft April 29, 2025 07:54
@matthiasschaub matthiasschaub force-pushed the osm-corine-comparison branch 2 times, most recently from 6d6af3b to 64ae315 Compare May 2, 2025 12:44
matthiasschaub and others added 18 commits May 5, 2025 11:21
@matthiasschaub
feat: add dummy for CORINE comparison indicator
c5a397e
@Gigaszi @matthiasschaub
success init of corine-comparison indicator
9323271
@Gigaszi @matthiasschaub
first draft of preprocess function
3e3a556
@Gigaszi @matthiasschaub
fix: add template.yaml to corine comparison indicator
663bec0
@matthiasschaub
make sql query postgres compatible
030a00a
@Gigaszi @matthiasschaub
fix: error in query and string formatting
e0a423a
@matthiasschaub
add pytest-asyncio as dev dep
393117a
@matthiasschaub
add fetch func to geodatabase module
0bab6c9 
and execute sql query against database in corine comparison indicator
@Gigaszi @matthiasschaub
feat: get clc_classes from database
9ce2264
@matthiasschaub
corine-comparison: calculate f1-score
cb5d871
@matthiasschaub
feat(corine-comparison): request model and approval tests
3548d19
@matthiasschaub
refactor: rename corine comparison to land cover thematic accuracy
b8ce5ea
@matthiasschaub
add land cover thematic accuracy request model and api tests
618a9c5
@matthiasschaub
test: ignore pytest-asyncio deprecation warning
3703e54 
of default scope changes
@matthiasschaub
test(approvaltests): add postfix parameter to PytestNamer
de4ee2b 
This enables the usage of the Namer multiple times in one test.
@matthiasschaub
build: add pygments as dev dep to make pytest pretty
11d43a1 
add syntax highlighting capabilities to pytest
@matthiasschaub
test(lc-thematic-accuracy): verify result description
cbbbac6
@matthiasschaub
test: do not test invalid result field
49579cc
@matthiasschaub matthiasschaub force-pushed the osm-corine-comparison branch from 31ccbc5 to 49579cc Compare May 5, 2025 09:25
@matthiasschaub matthiasschaub force-pushed the osm-corine-comparison branch from 984892f to 346bf80 Compare May 6, 2025 05:57
@matthiasschaub matthiasschaub changed the title feat: add dummy for CORINE comparison indicator feat: add Land Cover Thematic Accuracy indicator May 6, 2025
Gigaszi and others added 16 commits May 6, 2025 11:27
@Gigaszi
feat: add functionality to request single corine class
34e4f50
@Gigaszi
tests: add integration tests for single class functionalities
c0f38bf
@Gigaszi
feat: add query for single clc class
ccb61ce
@Gigaszi
fix: add missing fixture data for single class request mock
e08c0de
@Gigaszi
feat: new draft for indicator figure
f27e8d0
@matthiasschaub
use new table name for corine table
f6c7d6e
@matthiasschaub
fix: use absolute import statements
465e858
@matthiasschaub
fix: add bkg project to lulc topic
c012952 
and add mocks to tests
@matthiasschaub
refactor: clearer distinction between multi and single class workflow
0d1be7f
@matthiasschaub
test: rename tests and re-approve
fa89e41
@matthiasschaub
improve plotly figure
e2e1e1e
@matthiasschaub
refactor: show bar chart for multi class
d13063d
@matthiasschaub
feat: improve multiclass figure
60939cc
@Gigaszi
feat: add new binary heatmap for single class
103584a
@Gigaszi
feat: add result descriptions
77dd108
@matthiasschaub
feat: improve multiclass figure
c803cc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasschaub @Gigaszi