Skip to content

Roll back changes for shared context #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Roll back changes for shared context #4

wants to merge 1 commit into from

Conversation

dy
Copy link
Contributor

@dy dy commented May 13, 2016

Hi @mattdesl!

Seems that these lines are too naive for the case of shared gl context.

Also I would propose exposing shader instance as a property of render function, to allow for more flexible shader setup from outside, such as one-time uniform set etc. Now user has no control over shader program at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant