Fix Windows build #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensures that when the crate is in debug/release mode the C++ builds adapt
…into fix-windows-debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the Windows build issue by vendoring the dependencies. It includes the libSBML dependencies and ensures that libSBML is built statically. However, as noted in #2, merely including these dependencies did not completely resolve the problem.
The underlying issue was that the C runtime (CRT) used by the compiled C++ and Rust binaries differed, causing runtime errors. This has been fixed by setting
rustcflags in.cargo/config.tomlto enforce a static runtime, thereby avoiding a mix of static and dynamic libraries that could lead to runtime issues.Windows and MacOS (arm64 & x86) are now sucessfully built and tested. Only Linux is open to be fixed, but that's for another PR.
libsbmlbuild fails to link onwindows-latest#2