-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Reservoir protocol #14502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reservoir protocol #14502
Conversation
The adapter at projects/reservoir-protocol exports TVL:
|
5ec4f63
to
fc51532
Compare
I am not sure why the tests are failing, do we need to define an rpc for bera? |
The adapter at projects/reservoir-protocol exports TVL:
|
Resolved |
@0xngmi They're passing now. |
The adapter at projects/reservoir-protocol exports TVL:
|
The adapter at projects/reservoir-protocol exports TVL:
|
The adapter at projects/reservoir-protocol exports TVL:
|
I rewrote the adapter but I now realize I could leverage sumTokens or sumTokens2 but unfortunately I cannot find good docs at https://docs.llama.fi/list-your-project/how-to-write-an-sdk-adapter#line-4-input-parameter. Would be great if you can point me to a decent overview of the api reference. |
The adapter at projects/reservoir-protocol exports TVL:
|
The adapter at projects/reservoir-protocol exports TVL:
|
Figured it out but honestly the docs are very limited. If there's a comprehensive reference somewhere please point me to it |
holder: '0x0db79c0770E1C647b8Bb76D94C22420fAA7Ac181' | ||
}, | ||
{ | ||
name: 'rUSD-HONEY', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please export any TVL from ruSD-XXXX LPs as pool2
and exclude them from the main tvl
export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waynebruce0x This is not different than our core TVL. Instead of USDC being deployed into morpho for example, it's being bridged to Berachain and deployed into a liquidity.
pool2 makes no sense for this. This is our core TVL on Berachain. We are simply trying to denote our TVL on Berachain vs Mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we counting the collateral backing these bridged tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not double-counting if that's what you're asking.
USDC is deposited in our PSM, and once we bridge it to Berachain it's not counted on Mainnet anymore. Right now we are only counting USDC in our asset adapters (missing one) on Mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should count the USDC in the PSM instead of the rUSD supply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the protocol minting more rUSD backed by USDC to get exposure into this asset. Please merge this as it aligns with how the protocol generates yield
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you mean to get exposure into this asset
? can you explain a bit more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @bosswissam can you give more info about your USDC PSM? otherwise, we can not merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get USDC backing for rUSD on berachain instead of rUSD supply
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
package-lock.json
file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CIName (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):