Skip to content

Veda: Fail gracefully on query revert #14433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philipjames44
Copy link
Contributor

@philipjames44 philipjames44 commented Apr 24, 2025

Veda would like to backfill historical data and had an issue backfilling any earlier than Jan 20 2025. After some testing it became apparent certain contract queries revert for various reasons historically. This change allows us to fail gracefully such that the veda protocol TVL can be backfilled correctly.

@llamabutler
Copy link

The adapter at projects/veda exports TVL:

ethereum                  1.63 B
berachain                 557.26 M
sonic                     115.44 M
base                      5.42 M
bob                       3.04 M
arbitrum                  2.56 M
bsc                       2.35 M

total                    2.31 B 

@waynebruce0x
Copy link
Collaborator

These try catches would mean our monitoring will not flag when Veda has drops in TVL which will make debugging impossible. Also when backfilling we wont know if the data is accurate until its written to production

@waynebruce0x waynebruce0x self-assigned this Apr 24, 2025
@llamabutler
Copy link

The adapter at projects/veda exports TVL:

ethereum                  1.63 B
berachain                 555.68 M
sonic                     115.89 M
base                      5.44 M
bob                       3.05 M
arbitrum                  2.57 M
bsc                       2.35 M

total                    2.32 B 

@philipjames44
Copy link
Contributor Author

@waynebruce0x you're right thanks for pointing that out. I removed the try catches and just left the better share handling. let me know if this works

@waynebruce0x
Copy link
Collaborator

allowing failed RPC calls can also result in inaccurate data - is this specifically for backfilling? We could run your code in CLI to backfill and then keep the current implementation for future data?

@philipjames44
Copy link
Contributor Author

@waynebruce0x yes this is specifically for backfilling. historically some RPC calls fail at a handful of blocks due to a variety of reasons (happy to chat through those) but really its only a few isolated incidents.

If it's possible to run this just to do a backfill once off and keep the code as it stands already that would be super appreciated.

@waynebruce0x
Copy link
Collaborator

Hey I've just got around to running this and I'm running into some issues. Is there an easier way I can contact you? Discord or telegram?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants