-
Notifications
You must be signed in to change notification settings - Fork 392
[datadog_compliance_resource_evaluation_filter] Adding resource evaluation filters as a terraform resource #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left some suggestions and flagged a typo in the markdown file
…ion of filters and prevent performance issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just some comments/questions on error handling.
I'd also like to see example usage so I can get a feel for the user experience here.
datadog/fwprovider/resource_datadog_csm_resource_evaluation_filter.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_csm_resource_evaluation_filter.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_csm_resource_evaluation_filter.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_csm_resource_evaluation_filter.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_csm_resource_evaluation_filter.go
Outdated
Show resolved
Hide resolved
900b8e3
to
8123dc6
Compare
datadog/tests/resource_datadog_compliance_resource_evaluation_filter_test.go
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_compliance_resource_evaluation_filter.go
Show resolved
Hide resolved
datadog/tests/resource_datadog_compliance_resource_evaluation_filter_test.go
Outdated
Show resolved
Hide resolved
datadog/tests/resource_datadog_compliance_resource_evaluation_filter_test.go
Outdated
Show resolved
Hide resolved
datadog/fwprovider/resource_datadog_compliance_resource_evaluation_filter.go
Outdated
Show resolved
Hide resolved
…ance resource evaluation filters
…ternal property of terraform)
Summary
Adding resource evaluation filters resources to the terraform provider.
Allows the management of resource evaluation filters in terraform.
Why
Customers requested a way to manage resource evaluation filters through code, instead of relying on the user interface.
Testing
The resources were tested via newly created integration tests, as well as through manually creating new filters in a local environment.
Usage Examples
Takes about 1-2 seconds for 100 tags.
Terraform Plan
Terraform Create
Terraform Update
Terraform Destroy