Skip to content

[datadog_compliance_resource_evaluation_filter] Adding resource evaluation filters as a terraform resource #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Matzoc
Copy link

@Matzoc Matzoc commented May 8, 2025

Summary

Adding resource evaluation filters resources to the terraform provider.
Allows the management of resource evaluation filters in terraform.

Why

Customers requested a way to manage resource evaluation filters through code, instead of relying on the user interface.

Testing

The resources were tested via newly created integration tests, as well as through manually creating new filters in a local environment.

Usage Examples

Takes about 1-2 seconds for 100 tags.

Terraform Plan

Screenshot 2025-05-22 at 16 19 09

Terraform Create

Screenshot 2025-05-22 at 16 18 42

Terraform Update

Screenshot 2025-05-22 at 16 18 16

Terraform Destroy

Screenshot 2025-05-22 at 16 17 16

@Matzoc Matzoc marked this pull request as ready for review May 21, 2025 10:31
@Matzoc Matzoc requested review from a team as code owners May 21, 2025 10:31
@Matzoc Matzoc changed the title Adding resource evaluation filters as a terraform resource [datadog_csm_resource_evaluation_filter] Adding resource evaluation filters as a terraform resource May 21, 2025
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some suggestions and flagged a typo in the markdown file

@Matzoc Matzoc requested a review from buraizu May 22, 2025 11:18
Copy link

@nickwallen nickwallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just some comments/questions on error handling.

I'd also like to see example usage so I can get a feel for the user experience here.

@Matzoc Matzoc changed the title [datadog_csm_resource_evaluation_filter] Adding resource evaluation filters as a terraform resource [datadog_compliance_resource_evaluation_filter] Adding resource evaluation filters as a terraform resource May 22, 2025
@Matzoc Matzoc force-pushed the manuel.costa/resource-filter-resource branch from 900b8e3 to 8123dc6 Compare May 22, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants