Skip to content

Remove source and destination lists #29863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Remove source and destination lists #29863

merged 2 commits into from
Jun 11, 2025

Conversation

maycmlee
Copy link
Contributor

@maycmlee maycmlee commented Jun 10, 2025

What does this PR do? What is the motivation?

Remove lists because the nav already has this so having both is redundant.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@maycmlee maycmlee requested a review from a team as a code owner June 10, 2025 18:28
Copy link
Contributor

github-actions bot commented Jun 10, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

@buraizu buraizu self-assigned this Jun 10, 2025
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and approving, but just wanted to flag a couple of minor points for /destinations/_index.md:

  • Amazon Security Lake is missing from the nav. Is this because it's in Preview?
  • It looks like the intention is to have the nav organized alphabetically, and as such Syslog should be after Splunk HEC and Sumo Logic Hosted Collector. If it's not intended to be alphabetical, feel free to ignore this!

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jun 11, 2025
@maycmlee
Copy link
Contributor Author

Looks good and approving, but just wanted to flag a couple of minor points for /destinations/_index.md:

  • Amazon Security Lake is missing from the nav. Is this because it's in Preview?
  • It looks like the intention is to have the nav organized alphabetically, and as such Syslog should be after Splunk HEC and Sumo Logic Hosted Collector. If it's not intended to be alphabetical, feel free to ignore this!

Thanks @buraizu! ASL hasn't actually be released yet so that's why it's not there. The nav is supposed to be alphabetically so I moved Syslog to where it should be. Thanks for catching that!

@maycmlee maycmlee merged commit beeb916 into master Jun 11, 2025
15 checks passed
@maycmlee maycmlee deleted the may/remove-lists branch June 11, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants