Skip to content

👷 fix update-branch script success condition #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

👷 fix update-branch script success condition #3612

merged 1 commit into from
Jun 10, 2025

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

The script was succeeded even if the operation failed. Also, there was no log output.

Changes

  • Check if there is any FAILURE in feedbacks
  • Format and print all feedbacks

Test instructions

This will be shown in main pipelines, but check this job for a preview

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner June 6, 2025 15:11
@BenoitZugmeyer BenoitZugmeyer merged commit bf529a9 into main Jun 10, 2025
20 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/investigate-update-branch-script branch June 10, 2025 08:17
BeltranBulbarellaDD pushed a commit that referenced this pull request Jun 10, 2025
@BenoitZugmeyer @BeltranBulbarellaDD
👷 fix update-branch script success condition (#3612)
1ea0fc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-lebeau thomas-lebeau thomas-lebeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenoitZugmeyer @thomas-lebeau