Skip to content

👌 [RUM-10290] Remove built extensions from ignored in eslint.config #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BeltranBulbarellaDD
Copy link
Contributor

@BeltranBulbarellaDD BeltranBulbarellaDD commented Jun 6, 2025

… ignored in eslint.config.mjs

Motivation

Currently we ignore the browser extensions we use for testing form eslint rules. The aim of this PR is to remove that rule.

Changes

Added a ts.config file to base-extension. Migrated files to be in typescript.
Fixed linter errors in base-extension

Test instructions

Should build, pass CI and most importantly be able to release.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@BeltranBulbarellaDD BeltranBulbarellaDD changed the title Added ts files, modified build-extensions.js, removed extensions from… [RUM-10290] Remove built extensions from ignored in eslint.config Jun 6, 2025
@BeltranBulbarellaDD BeltranBulbarellaDD changed the title [RUM-10290] Remove built extensions from ignored in eslint.config 👌 [RUM-10290] Remove built extensions from ignored in eslint.config Jun 6, 2025
Copy link

cit-pr-commenter bot commented Jun 6, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 146.84 KiB 146.84 KiB 0 B 0.00%
Rum Recorder 18.02 KiB 18.02 KiB 0 B 0.00%
Rum Profiler 4.63 KiB 4.63 KiB 0 B 0.00%
Logs 51.72 KiB 51.72 KiB 0 B 0.00%
Flagging 0 B 935 B 935 B N/A%
Rum Slim 106.46 KiB 106.46 KiB 0 B 0.00%
Worker 23.59 KiB 23.59 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.007 0.007 -0.000
addaction 0.027 0.022 -0.005
addtiming 0.005 0.005 -0.000
adderror 0.025 0.020 -0.005
startstopsessionreplayrecording 0.001 0.001 -0.000
startview 0.005 0.005 -0.000
logmessage 0.025 0.022 -0.003
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 25.06 KiB 25.69 KiB 650 B
addaction 52.27 KiB 56.08 KiB 3.80 KiB
addtiming 24.97 KiB 26.25 KiB 1.28 KiB
adderror 56.36 KiB 57.25 KiB 914 B
startstopsessionreplayrecording 25.34 KiB 24.74 KiB -618 B
startview 429.73 KiB 430.36 KiB 651 B
logmessage 56.07 KiB 57.36 KiB 1.29 KiB

🔗 RealWorld

@BeltranBulbarellaDD BeltranBulbarellaDD marked this pull request as ready for review June 6, 2025 13:39
@BeltranBulbarellaDD BeltranBulbarellaDD requested a review from a team as a code owner June 6, 2025 13:39
@BeltranBulbarellaDD
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 10, 2025

View all feedbacks in Devflow UI.

2025-06-10 07:19:45 UTC ℹ️ Start processing command /to-staging


2025-06-10 07:19:53 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 0s (p90)

Commit d2b430ed94 will soon be integrated into staging-24.


2025-06-10 07:35:40 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit d2b430ed94 has been merged into staging-24 in merge commit 15d1aff633.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-24

dd-mergequeue bot added a commit that referenced this pull request Jun 10, 2025
…tensions (#3609) into staging-24

Integrated commit sha: d2b430e

Co-authored-by: BeltranBulbarellaDD <[email protected]>
@BeltranBulbarellaDD BeltranBulbarellaDD merged commit 50f838e into main Jun 10, 2025
20 checks passed
@BeltranBulbarellaDD BeltranBulbarellaDD deleted the beltran.bulbarella/RUM-10290-Add-eslint-to-build-browser-extensions branch June 10, 2025 12:02
BeltranBulbarellaDD added a commit that referenced this pull request Jun 10, 2025
…3609)

* Added ts files, modified build-extensions.js, removed extensions from ignored in eslint.config.mjs

* fixed prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants