-
Notifications
You must be signed in to change notification settings - Fork 156
Flagging SDK Dev Branch #3586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
leoromanovsky
wants to merge
32
commits into
main
Choose a base branch
from
flagging-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Flagging SDK Dev Branch #3586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenFeature recommends relying on web-sdk package instead of core. The downside is that web-sdk is not side-effect free, so it's better if we don't depend on StandardResolutionReasons. The good news is that TypeScript should be able to check literals against enum and using 'DEFAULT' literal is shorter and reduces bundle size a bit.
Remove peer dependencies from `dependencies` list. Also use caret range, so users are free to select SDK version.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
==========================================
- Coverage 92.37% 92.13% -0.25%
==========================================
Files 323 326 +3
Lines 8132 8189 +57
Branches 1840 1849 +9
==========================================
+ Hits 7512 7545 +33
- Misses 620 644 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
…age (#3593) * 👷[FFL-125] support npm pre-release with uuid tagging on flagging package * switch codeowners ordering so packages/flagging gets matched * pushd/popd
* FFL-1548: fix API path * fix path to package.json in integrate script * lint
* flagging sdk correctly matches configuration api * fallback to precompute api v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Test instructions
Checklist