Skip to content

Flagging SDK Dev Branch #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Flagging SDK Dev Branch #3586

wants to merge 32 commits into from

Conversation

leoromanovsky
Copy link
Contributor

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

leoromanovsky and others added 25 commits May 27, 2025 15:56
OpenFeature recommends relying on web-sdk package instead of core.

The downside is that web-sdk is not side-effect free, so it's better
if we don't depend on StandardResolutionReasons. The good news is that
TypeScript should be able to check literals against enum and using
'DEFAULT' literal is shorter and reduces bundle size a bit.
Remove peer dependencies from `dependencies` list. Also use caret
range, so users are free to select SDK version.
Revert previous attempts at polyfilling globalThis (commits
013e074 and
e5103f7)
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 59.64912% with 23 lines in your changes missing coverage. Please review.

Project coverage is 92.13%. Comparing base (0db1340) to head (cbafc82).

Files with missing lines Patch % Lines
packages/flagging/src/openfeature/provider.ts 51.61% 15 Missing ⚠️
packages/flagging/src/configuration/wire.ts 53.33% 7 Missing ⚠️
packages/flagging/src/evaluation.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   92.37%   92.13%   -0.25%     
==========================================
  Files         323      326       +3     
  Lines        8132     8189      +57     
  Branches     1840     1849       +9     
==========================================
+ Hits         7512     7545      +33     
- Misses        620      644      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cit-pr-commenter bot commented Jun 3, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 146.75 KiB 146.75 KiB 0 B 0.00%
Rum Recorder 18.02 KiB 18.02 KiB 0 B 0.00%
Rum Profiler 4.63 KiB 4.63 KiB 0 B 0.00%
Logs 51.68 KiB 51.68 KiB 0 B 0.00%
Flagging 0 B 25.96 KiB 25.96 KiB N/A%
Rum Slim 106.38 KiB 106.38 KiB 0 B 0.00%
Worker 23.59 KiB 23.59 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.008 0.017 0.009
addaction 0.024 0.061 0.038
addtiming 0.005 0.015 0.009
adderror 0.023 0.061 0.038
startstopsessionreplayrecording 0.001 0.002 0.001
startview 0.006 0.011 0.005
logmessage 0.023 0.044 0.021
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 26.99 KiB 26.08 KiB -928 B
addaction 52.75 KiB 52.29 KiB -472 B
addtiming 25.05 KiB 25.08 KiB 28 B
adderror 55.34 KiB 54.90 KiB -455 B
startstopsessionreplayrecording 23.65 KiB 24.60 KiB 968 B
startview 429.11 KiB 428.59 KiB -529 B
logmessage 60.23 KiB 57.25 KiB -3052 B

🔗 RealWorld

leoromanovsky and others added 3 commits June 4, 2025 10:31
…age (#3593)

* 👷[FFL-125] support npm pre-release with uuid tagging on flagging package

* switch codeowners ordering so packages/flagging gets matched

* pushd/popd
* FFL-1548: fix API path
* fix path to package.json in integrate script
* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants