♻️ [RUM-10005] Exposes addEvent
instead of strategy
to plugins
#3567
+214
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor plugin integration to use
addEvent
instead ofstrategy
. This gives plugins author the ability to better integrate with native the RUM events (e.g. click actions)Changes
strategy
object byaddEvent
method in plugin'sonInit()
method.addEvent
accept a subset ofRumEvent
as defined by rum-event-format and thedomainContext
to be passed tobeforeSend
.addEvent
will then send the event to the lifecycleRAW_RUM_EVENT_COLLECTED
to be assembled and send.addEvent
in the react pluginTest instructions
Additionally you can compare the error event before and after the refactor, they should be mostly identical
Checklist