Skip to content

Benoit/simplify replica #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Benoit/simplify replica #3552

wants to merge 6 commits into from

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.44%. Comparing base (c947b2d) to head (7fabb75).

Files with missing lines Patch % Lines
...src/domain/configuration/transportConfiguration.ts 0.00% 1 Missing ⚠️
packages/core/src/domain/telemetry/telemetry.ts 80.00% 1 Missing ⚠️
packages/logs/src/transport/startLogsBatch.ts 75.00% 1 Missing ⚠️
packages/rum-core/src/transport/startRumBatch.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3552      +/-   ##
==========================================
- Coverage   92.44%   92.44%   -0.01%     
==========================================
  Files         322      321       -1     
  Lines        8129     8113      -16     
  Branches     1838     1831       -7     
==========================================
- Hits         7515     7500      -15     
+ Misses        614      613       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cit-pr-commenter bot commented May 20, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 145.86 KiB 145.86 KiB N/A%
Rum Recorder 0 B 18.03 KiB 18.03 KiB N/A%
Rum Profiler 0 B 4.73 KiB 4.73 KiB N/A%
Logs 0 B 49.89 KiB 49.89 KiB N/A%
Rum Slim 0 B 105.35 KiB 105.35 KiB N/A%
Worker 0 B 23.59 KiB 23.59 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.005 0.005
addaction N/A 0.081 0.081
addtiming N/A 0.002 0.002
adderror N/A 0.088 0.088
startstopsessionreplayrecording N/A 0.021 0.021
startview N/A 0.542 0.542
logmessage N/A 0.037 0.037
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 26.26 KiB NaN KiB
addaction NaN KiB 54.46 KiB NaN KiB
addtiming NaN KiB 24.43 KiB NaN KiB
adderror NaN KiB 60.47 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 23.08 KiB NaN KiB
startview NaN KiB 427.35 KiB NaN KiB
logmessage NaN KiB 51.17 KiB NaN KiB

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/simplify-replica branch from c8ce886 to d26692e Compare May 21, 2025 08:24
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/simplify-replica branch from d26692e to 7fabb75 Compare June 11, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants