Skip to content

Refactor/standard naming #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 27, 2024
Merged

Refactor/standard naming #278

merged 7 commits into from
Mar 27, 2024

Conversation

HaydenOrz
Copy link
Collaborator

@HaydenOrz HaydenOrz commented Mar 26, 2024 •
edited
Loading

主要变更

  1. 重命名 文件夹 flinksql 为 flink
  2. 重命名 pgsql 为 postgresql
  3. 重命名 trinosql 为 trino
  4. 将所有的默认导出修改为具名导出
  5. 重命名 BasicParser 为 BasicSQL
  6. 将类得成员函数统一为普通函数

LuckyFBB
LuckyFBB reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@LuckyFBB LuckyFBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前说的 ref 的那个没有一起改吗

@HaydenOrz
Copy link
Collaborator Author

之前说的 ref 的那个没有一起改吗

ref 要不要改我还在考虑，属于是比较严重的破坏性变更

@HaydenOrz HaydenOrz force-pushed the refactor/standard_naming branch from a892beb to e08a3ef Compare March 27, 2024 02:11
@HaydenOrz HaydenOrz merged commit bb0fad1 into DTStack:main Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuckyFBB LuckyFBB LuckyFBB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaydenOrz @LuckyFBB