Small improvements to PerturbationAdvectionOpenBoundaryCondition interface
#4394
+20
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Apr 14, 2025
src/BoundaryConditions/perturbation_advection_open_boundary_matching_scheme.jl
Outdated
Show resolved
Hide resolved
glwagner
reviewed
Apr 17, 2025
| @@ -114,7 +114,7 @@ end | |||
|
|
|||
| τ̃ = Δt / τ | |||
|
|
|||
| u₁ⁿ⁺¹ = (uᵢⁿ - U * uᵢ₋₁ⁿ⁺¹ + ūⁿ⁺¹ * τ̃) / (1 + τ̃ - U) | |||
| u₁ⁿ⁺¹ = isinf(τ̃) ? ūⁿ⁺¹ : (uᵢⁿ - U * uᵢ₋₁ⁿ⁺¹ + ūⁿ⁺¹ * τ̃) / (1 + τ̃ - U) | |||
There was a problem hiding this comment.
can you organize this code into "paragraphs" (we don't want to use double space code I feel)
There was a problem hiding this comment.
Is this what you're suggesting?
Suggested change
| u₁ⁿ⁺¹ = isinf(τ̃) ? ūⁿ⁺¹ : (uᵢⁿ - U * uᵢ₋₁ⁿ⁺¹ + ūⁿ⁺¹ * τ̃) / (1 + τ̃ - U) | |
| if isinf(τ̃) | |
| u₁ⁿ⁺¹ = ūⁿ⁺¹ | |
| else | |
| u₁ⁿ⁺¹ = (uᵢⁿ - U * uᵢ₋₁ⁿ⁺¹ + ūⁿ⁺¹ * τ̃) / (1 + τ̃ - U) | |
| end |
There was a problem hiding this comment.
no no I just mean removing some vertical white space
There was a problem hiding this comment.
Ah I see. Yeah I agree with you. I also find it harder to read. I'll improve that.
There was a problem hiding this comment.
Done. Can you check?
glwagner
reviewed
Apr 17, 2025
src/BoundaryConditions/perturbation_advection_open_boundary_matching_scheme.jl
Show resolved
Hide resolved
jagoosw
reviewed
Apr 18, 2025
src/BoundaryConditions/perturbation_advection_open_boundary_matching_scheme.jl
Outdated
Show resolved
Hide resolved
|
@jagoosw can you please write a couple of sentences about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.