Skip to content

Run prettier on scripts #12584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Run prettier on scripts #12584

merged 2 commits into from
Apr 30, 2025

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Apr 25, 2025

Description

I'm not really sure why we were not running prettier on our scripts scripts. Might've just been missed. This just un-ignores that directory and runs prettier on those files.

Issue number and link

No issue

Testing plan

Not really anything, make sure CI linting passes

  • Check the local server still works
  • Check builds still work

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@jjspace jjspace requested a review from ggetz April 29, 2025 18:43
Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @jjspace! Once CI passes with the updated code from main, I'll merge.

@ggetz ggetz added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit ff26431 Apr 30, 2025
5 checks passed
@ggetz ggetz deleted the prettier-scripts branch April 30, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants