-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Splat shader Fix: Unable to obtain the position on the model using pickPosition when loading 3dgs Gaussian data #12542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: splat-shader
Are you sure you want to change the base?
Conversation
…en loading 3d Gaussian data Fix: Unable to obtain the position on the model using pickPosition when loading 3d Gaussian data
…en loading 3d Gaussian data Fix: Unable to obtain the position on the model using pickPosition when loading 3d Gaussian data
Thank you for the pull request, @h5developers! Welcome to the Cesium community! In order for us to review your PR, please complete the following steps:
Review Pull Request Guidelines to make sure your PR gets accepted quickly. |
Thanks for the suggestion @h5developers. @keyboardspecialist Would you mind taking a pass on this PR and decide if you would like to incorporate it into your branch? |
Yes, this is a change we already discussed making. This is necessary for not only picking, but for occlusion with other objects in the scene. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. These flags are needed going forward.
@h5developers I don't think we have a CLA on file for you. We need one to merge this PR. Could you please send in a Contributor License Agreement (CLA)? |
Hi @yuqingyang0129, I dropped a comment in #12545. Could you please make the CONTRIBUTORS.md update in this branch? |
@keyboardspecialist Is this still applicable given the new PR #12582? If so, we can get this cleaned up and retargeted. if not, we'll close. |
Description
Issue number and link
Testing plan
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change