-
Notifications
You must be signed in to change notification settings - Fork 7
Prep v1.0.12 #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep v1.0.12 #179
Conversation
Add RParam pd and qd in ``DCPF1`` for easy access to load
Bug fix in ``RoutineBase.export_csv()`` when path is specified
Update codecov tests config
Fix bug in ``io.matpower.system2mpc`` with multiple PQ at one bus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares version v1.0.12 and addresses several issues while introducing new features for easier access and improved export functionality. The key changes include:
- Adding RParam attributes pd and qd to DCPF1 in the pypower routine.
- Fixing bugs in RoutineBase.export_csv and in io.matpower.system2mpc related to handling paths and multiple PQ loads.
- Updating tests, examples, documentation, and CI workflows to support these changes.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/test_rtn_dcopf.py | Added test for export_csv functionality. |
tests/test_paths.py | Introduced tests for get_export_path behavior. |
tests/test_io.py | Added test_system2mpc_pq to verify multiple PQ handling. |
examples/ex4.ipynb, demo notebooks | Updated output strings and documentation in notebooks. |
docs/source/release-notes.rst | Updated release notes for v1.0.12 and fixed texts. |
ams/utils/paths.py | Added a new get_export_path function. |
ams/system.py | Updated export wrappers to use get_export_path and added wrapper notes. |
ams/routines/routine.py | Modified export_csv to use get_export_path. |
ams/routines/pypower.py | Added RParam pd and qd attributes for StaticLoad. |
ams/io/psse.py, matpower.py, matprocessor.py | Enhanced docstrings and notes in export functions. |
CI config files (.github/workflows/codecov.yml, .codecov.yml, .codacy.yml) | Adjusted test and coverage reporting configurations. |
Comments suppressed due to low confidence (3)
ams/system.py:773
- The function call 'wrtite_m' appears to be a typo. It likely should be 'write_m' to correctly call the intended wrapper method.
return wrtite_m(self, outfile=outfile, overwrite=overwrite)
ams/routines/pypower.py:135
- [nitpick] The attribute name 'pd' might conflict with the commonly used alias 'pd' (e.g., for pandas) imported elsewhere. Consider renaming it (for example, to 'p_demand') to avoid potential confusion.
self.pd = RParam(info='active demand', name='pd', tex_name=r'p_{d}', model='StaticLoad', src='p0', unit='p.u.',)
ams/utils/paths.py:292
- The function get_export_path uses 'logger' but does not import or define it. Please import logging (e.g., 'import logging' and 'logger = logging.getLogger(name)') to ensure the logger is available.
logger.info("Input file name not detected. Using `Untitled`.")
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
@trag-bot didn't find any issues in the code! ✅✨ |
Pull request summary
|
@trag-bot didn't find any issues in the code! ✅✨ |
Pull request summary
|
DCPF1
for easy access to loadRoutineBase.export_csv
when path is specifiedio.matpower.system2mpc
with multiple PQ at one bus