Skip to content

Misc #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Apr 14, 2025
Merged

Misc #134

merged 42 commits into from
Apr 14, 2025

Conversation

jinningwang
Copy link
Member

@jinningwang jinningwang commented Apr 14, 2025

  • Switch to Area from Zone for zonal calculation
  • Extend common parameters in groups StaticGen and StaticLoad with area
  • Set case pjm5bus_demo.xlsx as a all-inclusive case
  • Include module MatProcessor in the API documentation
  • Improve Line parameters correction in System.setup()
  • Make func interface._to_andes_pflow public
  • Update case files

@jinningwang jinningwang requested a review from Copilot April 14, 2025 05:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 48 out of 50 changed files in this pull request and generated 2 comments.

Files not reviewed (2)
  • docs/source/api.rst: Language not supported
  • docs/source/release-notes.rst: Language not supported
Comments suppressed due to low confidence (1)

ams/interface.py:116

  • The removal of the sync_adsys() call in the to_andes_pflow() function might lead to unsynchronized parameter values between AMS and ANDES systems. Please verify whether the synchronization step should be retained.
    return adsys

@jinningwang jinningwang requested a review from Copilot April 14, 2025 06:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 53 out of 53 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

ams/interface.py:108

  • Typo in parameter 'no_outpu'; it should be 'no_output' to ensure that the andes_System function receives the correct argument.
adsys = andes_System(no_outpu=no_output, default_config=default_config, **kwargs)

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.15% (target: -10.00%) 100.00% (target: 0.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a0b206d) 13943 8003 57.40%
Head commit (b6bdcf5) 13958 (+15) 8032 (+29) 57.54% (+0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#134) 83 83 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.65%. Comparing base (a0b206d) to head (b6bdcf5).
Report is 44 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
+ Coverage    78.59%   78.65%   +0.05%     
===========================================
  Files           71       71              
  Lines         5967     5959       -8     
===========================================
- Hits          4690     4687       -3     
+ Misses        1277     1272       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jinningwang jinningwang merged commit 1d77f33 into develop Apr 14, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant