Add sandbox gamemode effects #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrefgtzweve
reviewed
Jan 30, 2024
| @@ -66,5 +66,16 @@ GmodScripts_EffectWhitelist = { | |||
| acf_heat_explosion = true, | |||
| simfphys_engine_smoke = true, | |||
| eff_jack_plasmaarc = true, | |||
|
|
|||
| balloon_pop = true, | |||
There was a problem hiding this comment.
balloon_pop can be abused to cause severe lag
There was a problem hiding this comment.
is there a way to remove it from the pr then?
There was a problem hiding this comment.
if youre using the web editor you can do it here
https://github.com/ReasonableScripts/cfc_gmod_scripts/blob/patch-1/lua/cfc_gmod_scripts/effects_whitelist/sh_init.lua
There was a problem hiding this comment.
did that fix it?
|
i think some of the other effects can be bad too but i don't recognize them directly by effect name, so i suggest someone tests this before its merged |
|
i just need to know what to remove :) |
the last few effects from the bottom of this page https://wiki.facepunch.com/gmod/Effects
sarahsturgeon
approved these changes
May 7, 2024
sarahsturgeon
requested changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the last few effects from the bottom of this page https://wiki.facepunch.com/gmod/Effects