-
-
Notifications
You must be signed in to change notification settings - Fork 6
Add built-in compiler for Fallout2 .ssl files #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Interesting, I haven't considered M1. Does it not run wine? I thought there was some compatilibility layer. |
Actually I have no idea, but i had an impression that it was not possible to run x86/x64 apps on M1 Macbooks. Anyways, even if it is possible then it still requires some setup. Having a embedded cross-platform compiler should be better user experience in my opinion. Maybe later we can enable it by default |
CI fails on |
Install sslc with hash check
Yes, looks like it was a bug in I changed installation script, now it will check hash of downloaded release file. Just more security. With hash check it is not a big difference where this file was downloaded from |
…to_check_package Use npm to install and to check integrity
So you aren't using an M1? What prompted you to work on this then? |
@burner1024 I am simple user, I want a button which makes everything for me. As user I want to install extension and to have a ready-to-use IDE. |
Well, the simplest way for that would be to just bundle compile.exe, I guess. Let's see when the upstream PR gets merged. |
Looks like PR into I think there is no blockers right now for merging this PR. I tested it locally and it works for me. There is a hash of the package in |
I'll look it over soon. |
@copilot review this |
I'd assign Copilot to review this PR if I had permission to add reviewers. :) |
Description
This PR embeds a WebAssembly-compiled
compile.exe
into this extension. It is under options flag and it is disabled by default.Having this compiler as WebAssembly build allow using this extension on non-intel processors, for example on Mac M1 or others.
Notes
Currently it uses compiled files from my repo but I will change it into sfall repo as soon as sfall-team/sslc#14 is merged
Lots of
any
because I have not found a good typescript definitions for emscripten module (@types/emscripten
have no.FS
property on theinstance
)I have not tested this on Windows but likely it will also work there