Add try-with-resources to annotation processor #45193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
samvaity,
vcolin7,
JonathanGiles and
srnagar
as code owners
|
API change check API changes are not detected in this pull request. |
vcolin7
reviewed
May 3, 2025
| // Always close the network response in this situation as converting to a byte[] will read the entire | ||
| // response. This should complete the connection, but let's be safe. This must be done after getting the | ||
| // byte[] though. | ||
| closeResponse(body, "Close the network response as the body should be consumed."); | ||
|
|
||
| // Return responseBodyBytes as-is which will have the behavior of null -> null, empty -> empty, and |
There was a problem hiding this comment.
nit; responseBodyBytes is not used as a variable any longer.
| boolean returnIsResponse = TypeConverter.isResponseType(returnType); | ||
|
|
||
| // TODO (alzimmer): Base64Uri needs to be handled. Determine how this will show up in code generation and then | ||
| // add support for it. | ||
| if (entityType == Void.TYPE || entityType == Void.class) { | ||
| // Return is void, Void, or Response<Void>, close the network response and return null as the value. | ||
| if (returnType.getKind() == TypeKind.VOID) { |
There was a problem hiding this comment.
Does this mean we only close the response explicitly if the method returns void? Would we keep it open for Void or Response<Void>? Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes annotation processor to use a try-with-resources block when the
Response<BinaryData>will be closed. This ensures that if any errors occur before the network response is closed that resources won't be leaked.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines