Add try-with-resources to annotation processor

[alzimmermsft]

Description

Changes annotation processor to use a try-with-resources block when the Response<BinaryData> will be closed. This ensures that if any errors occur before the network response is closed that resources won't be leaked.

All SDK Contribution checklist:

• The pull request does not introduce [breaking changes]
• CHANGELOG is updated for new features, bug fixes or other significant changes.
• I have read the contribution guidelines.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[vcolin7]

General question: is there was a particular reason you chose to use try-with-resources in some tests and to explicitly call close() in others?

[vcolin7]

LGTM. I would still like to know the reason why some changes in tests use try-with-resources and others do not. Is it because of the return types?

[alzimmermsft]

LGTM. I would still like to know the reason why some changes in tests use try-with-resources and others do not. Is it because of the return types?

Yep! It's all about the return type.

If the return is something that fully reads the network response it should use try-with-resource. So that's byte[], String, Void, and a deserialized T type. void we don't as some compilers will complain about either an empty try-with-resource block or unused try-with-resource value. InputStream and BinaryData are left to those types to be closed themselves to close the network response.