[TESTING ONLY] Testing common changes required for duplicate artifactId #45181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
added
the
Central-EngSys
…nition is in there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm testing changes to API review creation. These changes will pass a list of PackageInfo files instead of a list of Artifact.Names. This allows passing around the PackageInfo object instead random pieces of data. Passing around the PackageInfo object also allows the FindArtifactForApiReviewFnV2 to correctly, and easily, find the sources jar since the PackageInfo file contains the Group. This eliminates the janky code that had to exist in the original FindArtifactForApiReviewFn which had to play a guessing game with the group to get correct path to the sources.jar
The other changes are to update the detect-api-changes, updating to use the FindArtifactForApiReviewFnV2 instead of the FindArtifactForApiReviewFn also, in some cases, pass the PackageInfo file to functions so we're not loading the same PackageInfo multiple times.
Testing changes to this, at least for create-apireview.yml, requires a pipeline to be manually kicked off against the refs/merge of this PR to test yml path for PackageInfo files and the new script.