-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[NEW]mgmt resources, sync implementation for TaskGroup #45139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XiaofeiCao
wants to merge
3
commits into
Azure:main
Choose a base branch
from
XiaofeiCao:mgmt_taskgroup_invoke
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
API change check APIView has identified API level changes in this PR and created following API reviews. |
6 tasks
/azp run java - pullrequest |
Azure Pipelines failed to run 1 pipeline(s). |
pullrequest CI is having issue triggering... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
This PR is a copy of previous PR with commits squashed.
Last one fails strangely for revapi check: #45068 (comment)
One of the commit added
TaskGroup.failedFuture
with public visibility, and the next one changed it to private. Shouldn't trigger any breaking changes to 2.50.0... Not sure how this bug happens..Description
Part of sync-stack support for mgmt premium, and core-v2 if we want to keep premium packages.
Goal
TaskGroup
invocation without Reactor..Executor
to achieve task execution parallelism.Context
A rough flow of

TaskGroup.invokeAsync
:About this PR
TaskGroup.invoke
's major change is in step4 -> Concurrently execute tasks.Instead of
Flux.merge
, useCompletableFuture.allOf
to join allCompletableFuture
s kicked off byCompletableFuture.supplyAsync
with default or specifiedExecutor
.Specify
Executor
by settingsyncExecutor
inInvocationContext
, and execute viaTaskGroup.invoke(InvocationContext)
.To run task in the same thread as
TaskGroup.invoke
, setsyncExecutor
toRunnable::run
.Default
Executor
(if not specified) isForkJoinPool.commonPool()
, which is also the default Executor forCompletableFuture
.Test
Added tests in the same package as async ones, with
Sync
prefix.Future works
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines