This repository was archived by the owner on Jun 2, 2025. It is now read-only.
Select information_schema using a nested query to support WHERE, ORDER BY, and AS #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - support WHERE, ORDER... - support AS - ensure all schema fields are correct
bgrgicak
commented
Feb 3, 2025
Comment on lines
+1514
to
+1544
| /** | ||
| * TODO: Return real values for hardcoded column values. | ||
| */ | ||
| "(SELECT | ||
| 'def' as TABLE_CATALOG, | ||
| 'database' as TABLE_SCHEMA, | ||
| name as TABLE_NAME, | ||
| CASE type | ||
| WHEN 'table' THEN 'BASE TABLE' | ||
| WHEN 'view' THEN 'VIEW' | ||
| ELSE type | ||
| END as TABLE_TYPE, | ||
| 'InnoDB' as ENGINE, | ||
| 10 as VERSION, | ||
| 'Dynamic' as ROW_FORMAT, | ||
| 0 as TABLE_ROWS, | ||
| 0 as AVG_ROW_LENGTH, | ||
| 0 as DATA_LENGTH, | ||
| 0 as MAX_DATA_LENGTH, | ||
| 0 as INDEX_LENGTH, | ||
| 0 as DATA_FREE, | ||
| NULL as AUTO_INCREMENT, | ||
| NULL as CREATE_TIME, | ||
| NULL as UPDATE_TIME, | ||
| NULL as CHECK_TIME, | ||
| 'utf8mb4_general_ci' as TABLE_COLLATION, | ||
| NULL as CHECKSUM, | ||
| '' as CREATE_OPTIONS, | ||
| '' as TABLE_COMMENT | ||
| FROM sqlite_master | ||
| WHERE type IN ('table', 'view'))", |
There was a problem hiding this comment.
I just left a TODO here instead of working on a way to get real values for hardcoded columns.
@JanJakes I assumed that the work you are doing with AST will resolve this longterm, so I didn't invest extra time in working on it as this is already an improvement that will allow queries to execute correctly.
There was a problem hiding this comment.
@bgrgicak Yes, it will. The AST driver already store all this information and uses it for SHOW and other statements, but it doesn't yet translate information_schema.tables to the correct table name.
ashfame
reviewed
Feb 3, 2025
ashfame
approved these changes
Feb 4, 2025
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR information schema queries always executed hardcoded queries, which made it impossible to use WHERE, ORDER, and AS in information schema queries.
This PR adds support for executing information schema queries instead of running hardcoded queries defined by this plugin. This means we can use WHERE, ORDER, AS, and other select query clauses.
Thanks @ashfame for working with me on this PR!
Testing