-
Notifications
You must be signed in to change notification settings - Fork 28
Demo Project: Convert Groups to Buildable Folder references #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Demo Project: Convert Groups to Buildable Folder references #676
Conversation
|
App Name | Gravatar Prototype Build | |
Build Number | 2148 | |
Version | PR #676 | |
Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
Commit | 0a7a1d7 | |
Installation URL | 7m2ran1p333t8 |
Just a routine update before digging deeper into a build failure, see https://buildkite.com/automattic/gravatar-sdk-ios/builds/2135/steps?sid=0195d364-32bb-47c4-a10c-0da0a39806ce
Co-authored-by: Olivier Halligon <[email protected]>
2bffa51
to
0a7a1d7
Compare
This change caused us to stumble into a bug with fastlane. Fastlane will be fixing this. In the interim, we have a simple workaround in place (#681). Once Fastlane has a fix in place, we can update Fastlane, and revert that PR. In fact, we should revert most of that PR, but not all of it, since one commit actually fixes a typo (which would be a nice fix to keep). See that PR for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Description
This makes two changes:
Gravatar-Demo
group/folder in the project to a "Buildable Folder reference". This simplifies and reduces commit churn of the project file.Buildable Folder References in Xcode 16
Xcode 16 introduced "Buildable Folder references":
With a Buildable Folder reference:
Note that any file added to this folder is automatically added to the target, even if the file is added from outside of Xcode.
Testing Steps
Gravatar-Demo
folderCompile sources
Build Phase for theGravatar-Demo
targetDemo/Gravatar-Demo.xcodeproj/project.pbxproj
does NOT changeGravatar-Demo
folder (you can duplicate one)Compile sources
Build Phase for theGravatar-Demo
targetDemo/Gravatar-Demo.xcodeproj/project.pbxproj
does NOT change