refactor!: Simplify the core Android adapter API #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lding the inner adapter lock while raising queued events
…ng Adapter are implemented on the native side
…in the translation to Rust
…election key; it'll be false by default anyway
DataTriny
requested changes
May 4, 2025
platforms/android/src/adapter.rs
Outdated
| /// AccessKit node identified by the given virtual view ID. | ||
| /// Create an `AccessibilityNodeInfo` for the AccessKit node | ||
| /// corresponding to the given virtual view ID. Returns null if | ||
| /// there is no such node. | ||
| /// | ||
| /// The `host` paramter is the Android view for this adapter. |
There was a problem hiding this comment.
Suggested change
| /// The `host` paramter is the Android view for this adapter. | |
| /// The `host` parameter is the Android view for this adapter. |
platforms/android/src/adapter.rs
Outdated
| /// Create an `AccessibilityNodeInfo` for the AccessKit node | ||
| /// with the given focus type. Returns null if there is no such node. | ||
| /// | ||
| /// The `host` paramter is the Android view for this adapter. |
There was a problem hiding this comment.
Suggested change
| /// The `host` paramter is the Android view for this adapter. | |
| /// The `host` parameter is the Android view for this adapter. |
platforms/android/src/adapter.rs
Outdated
| /// Handle the provided hover event. | ||
| /// | ||
| /// The `action`, `x`, and `y` parameters must be retrieved from | ||
| /// the corresopnding properties on an Android motion event. These |
There was a problem hiding this comment.
Suggested change
| /// the corresopnding properties on an Android motion event. These | |
| /// the corresponding properties on an Android motion event. These |
| static CLASS: OnceCell<GlobalRef> = OnceCell::new(); | ||
| let global = CLASS.get_or_try_init(|| { | ||
| let global = CLASS.get_or_init(|| { |
There was a problem hiding this comment.
You could use a LazyCell here right? Or maybe even better, use std::sync::OnceLock until our MSRV permit us to use LazyLock, which would allow us to drop our dependency on once_cell.
DataTriny
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now even the
AdapterAPI prioritizes a simple interface and ease of integration over ease of internal implementation. And I believe it does so without meaningfully compromising performance. Specifically, this lower-level adapter still avoids the overhead of unnecessarily sending things across threads if the UI toolkit is already running on the Android UI thread.The two adapters can be tested with the demo applications in these two repositories:
Adapter: android-view; for the first time, this repo demonstrates a direct integration usingAdapterthat I'm happy withInjectingAdapter: xilem-to-do-mvc-android, an updated version of my test/demo app using GameActivity, winit, and xilem that was the only real test case for the original version of the Android adapter